Expose "raw":"1" from the API in MediaList #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@autopulated This looks like it is fine but I need to do some testing to see why i wasn't receiving the Did you make a bug ticket for this? I couldn't find one. |
|
No bug ticket sorry - the data in the added test is a section of a real http response from a gopro hero 12 black from opening the http endpoint in the browser. I don't think I had the labs firmware on it at that point, so it would have been up to date with the latest manual firmware update. |
tcamise-gpsw
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the raw flag on the media list (keeping it as a string value, and omitting it if the API response does not include it). This means you can list files and download the .gpr raws without needing to do a separate metadata request for each file.
Not sure if this is exactly the right way to do it, but by the time I'd modified my local version to add this thought I might as well see if it was useful upstream.
If this is a welcome addition I can update the changelog and docs if that's needed as well?